Add xLocCustomPowerShellScript in OneLoc task#16693
Merged
Conversation
3 tasks
Nigusu-Allehu
approved these changes
Apr 7, 2026
Member
|
hmm we don't have that issue in any other repo as far as I know. Are you sure you don't have some .gitattributes setting that strips the BOM? |
Contributor
Author
|
@akoeplinger Interesting, let me investigate that. I reach out to OneLoc folks, and this is what they suggested. Thanks! |
Contributor
Author
|
@akoeplinger I don't see anything in our repo that is changing the BOM and the xlf files are generated by OneLoc, I've seen other teams adding Can we merge this since it's not actually affecting anything and it's a parameter available in the original OneLocBuild@2 task? |
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Needed for NuGet.Client change NuGet/NuGet.Client#7259.
We use OneLoc to localize our strings, unfortunately OneLoc returns the files with BOM, and when moved to VMR BOM is removed, creating a "back and forth" PR creation between VMR and OneLoc, examples: https://github.com/NuGet/NuGet.Client/pull/7256/changes
https://github.com/NuGet/NuGet.Client/pull/7251/changes